[PATCH] s3-acl: fix free of uninitialized pointer

Jeremy Allison jra at samba.org
Fri Sep 23 12:47:04 MDT 2011


On Wed, Sep 21, 2011 at 03:59:52AM +0200, David Disseldorp wrote:
> Causing panic using vfs_acl_tdb/xattr.
> ---
>  source3/modules/vfs_acl_common.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
> index 9a1d13b..c08cb1b 100644
> --- a/source3/modules/vfs_acl_common.c
> +++ b/source3/modules/vfs_acl_common.c
> @@ -293,6 +293,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
>  		return status;
>  	}
>  
> +	ZERO_STRUCT(blob);
>  	status = get_acl_blob(talloc_tos(), handle, fsp, name, &blob);
>  	if (!NT_STATUS_IS_OK(status)) {
>  		DEBUG(10, ("get_nt_acl_internal: get_acl_blob returned %s\n",

Great catch !

https://bugzilla.samba.org/show_bug.cgi?id=8480


More information about the samba-technical mailing list