fixed ntlm_auth on samba4 aplha15.
rti
super.rti at gmail.com
Fri May 13 14:17:28 MDT 2011
Hello.
Thank you for your reply.
I fixed the patch.
1)
remove #if 0 and _SAMBA_BUILD_.
2)
correction to git ea0ac9cdfceae96b0e0be2531d9dea3b079bcd7f (date Sat
May 7 08:14:06 2011 +0200) was taken.
3)
fix my bug... :)
diff samba-master
http://rtilabs.net/files/2011_05_14/ntlm_auth.diff
git format patch
http://rtilabs.net/files/2011_05_14/ntlm_auth.git.patch
full source
http://rtilabs.net/files/2011_05_14/ntlm_auth.c
Thanks.
2011/5/12 Andrew Bartlett <abartlet at samba.org>:
> On Tue, 2011-05-10 at 18:20 +0900, rti wrote:
>> Hi.
>> The ntlm_auth on samba4 aplha15 did not work well, I tried to fix.
>>
>>
>> Send the fix.
>> http://rtilabs.net/files/2011_05_10/ntlm_auth.c
>>
>> or patch file.
>> http://rtilabs.net/files/2011_05_10/samba-4.0.0alpha15.ntlm_auth.patch
>
> Can you resend the patch to the list using diff -u, or better still make
> git commits and export with git format-patch -5 (or whatever number of
> patches you make). This will make it much easier to review.
>
> Please also split up the patches to address each issue if at all
> practical, and don't introduce extra _SAMBA_BUILD_ #ifdef statements or
> #if 0 statements.
>
> Thanks,
>
> Andrew Bartlett
>
> --
> Andrew Bartlett http://samba.org/~abartlet/
> Authentication Developer, Samba Team http://samba.org
>
>
>
More information about the samba-technical
mailing list