s4: remove calls "samdb_result_uint", "samdb_result_int64", "samdb_result_uint64" and "samdb_result_string"
Matthias Dieter Wallnöfer
mdw at samba.org
Thu Oct 14 07:59:26 MDT 2010
Andrew,
I've written the commit before your response and so it's now a bit
difficult to split-up. Therefore I prefer to merge all in common:
http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=commitdiff;h=f1c43f134d7b610ca20d9512d1334da8ac83bf5b.
It looks big but these are really only elementary substitutions.
I hope you are fine.
Greets,
Matthias
Andrew Bartlett wrote:
> On Thu, 2010-10-14 at 10:07 +0200, Matthias Dieter Wallnöfer wrote:
>
>> s4 developers,
>>
>> I would like to remove the mentioned calls since they became obsolete
>> quite some time ago. At the moment they're only wrappers to certain
>> "ldb_msg_find_attr_as_*" LDB library calls with the exact same signature.
>>
>> Therefore I offer the proposal to substitute all such calls with the
>> appropriate "ldb_msg_find_attr_as_*" routines and drop them.
>>
>> Any objections about such a patch?
>>
> Please go ahead. This is a worthwhile cleanup. Just be careful, and do
> at least one patch per changed function (ie 4 patches).
>
> Andrew Bartlett
>
>
More information about the samba-technical
mailing list