tstream_npa_connect_send()

[Andrew Bartlett]

On Mon, 2010-06-21 at 07:47 -0400, simo wrote:
> On Mon, 2010-06-21 at 21:06 +1000, Andrew Bartlett wrote:
> > On Mon, 2010-06-21 at 05:36 -0500, Matthias Dieter Wallnöfer wrote:
> > > The branch, master has been updated
> > >        via  276a1a7... s3/s4 - remove "talloc_tos()" from common code since s4 doesn't support it
> > >       from  c38f94e... s4:dsdb_load_partition_usn - free the right memory context (tmp_ctx)
> > > 
> > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > 
> > > 
> > > - Log -----------------------------------------------------------------
> > > commit 276a1a7fec1432bde870448f247ef710554c3ab8
> > > Author: Matthias Dieter Wallnöfer <mdw at samba.org>
> > > Date:   Mon Jun 21 12:33:57 2010 +0200
> > > 
> > >     s3/s4 - remove "talloc_tos()" from common code since s4 doesn't support it
> > >     
> > >     Please don't use this in common code parts until we change the policy regarding
> > >     it.
> > > 
> > > -----------------------------------------------------------------------
> > 
> > Thanks for fixing that.  For the named_pipe_auth part, that's my fault -
> > I forgot this was common code.  As we are using mem_ctx now, perhaps
> > ensure it goes away at the right point with an explicit talloc_free()?
> 
> Actually, I think that handling upper/lower case should probably be done
> at a higher level. In tstream_npa_connect_send() it represents just the
> file name to be used so it should be passed in the correct form an not
> manipulated in the function.

I looked at the levels when I did the patch, and this seemed to be the
right one.  This is where the concept of a named pipe (case insensitive)
becomes a filename, and is combined with a directory prefix.  Here we
meet the realities of unix, and need to lower case it. 

Andrew Bartlett