[PATCH] Rework schema handling in vampire client

Andrew Bartlett abartlet at samba.org
Sat Jun 12 01:54:05 MDT 2010


These patches rework the schema handling in 'net vampire' to replace the
'hand parse the DRS protocol' schema creation with a process that uses
the local, stored LDIF files to interpret the remote schema.  

The idea is that if we parse the DRS schema objects with the local
schema, we can build up a complete remote schema, and then use that to
parse the rest of the protocol stream. 

The reason I've started doing this now is that a recent change by mdw
made us sensitive to a bug in the DRS-based schema creation.  We could
fix that, but two implementations like this will always diverge.

Similarly, I replace the callbacks in torture/libnet/libnet_BecomeDC.c
code with those from libnet/libnet_vampire.  (The libnet_vampire code
was based on the torture code, but I didn't want break the existing
test, so I copied it.  Now that this code is mature, keeping two copies
just means we need to make changes in both). 

I've pushed this to vampire-fix-wip.  

Zahari: Can you check this with your test rig like we were using on the
phone earlier this week?
Kamen: Are you able to check on the way I'm using the prefixMap?  Is it
legitimate to use the remote prefixMap and the local schema like this,
as long as everything still resolves?
Metze: Do you mind that I've removed this code?  Both bits were
bit-rotting, and I think I've found a better solution. 

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-s4-provision-Allow-a-specific-prefix-map-to-be-loade.patch
Type: text/x-patch
Size: 6702 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-s4-dsdb-Remove-seperate-storage-of-msDS-IntID-from-s.patch
Type: text/x-patch
Size: 3786 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-s4-dsdb-Rework-the-vampire-schema-handling-to-conver.patch
Type: text/x-patch
Size: 12535 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-s4-dsdb-Keep-the-DRS-based-prefix-map-for-use-in-pro.patch
Type: text/x-patch
Size: 2523 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-s4-dsdb-Allow-the-setting-an-override-on-the-schema.patch
Type: text/x-patch
Size: 4997 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-s4-dsdb-Use-the-schema-from-our-local-provision-to-d.patch
Type: text/x-patch
Size: 23237 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-libnet-Make-the-libnet_vampire-default-callbacks-.patch
Type: text/x-patch
Size: 9102 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-libnet-Steal-ldb-and-lp_ctx-from-python-result-in.patch
Type: text/x-patch
Size: 943 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-torture-Rework-NET-API-BECOMEDC-test-to-use-libne.patch
Type: text/x-patch
Size: 26402 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100612/9f1901f0/attachment.pgp>


More information about the samba-technical mailing list