drsuapi.idl flags

Stefan (metze) Metzmacher metze at samba.org
Fri Feb 5 04:05:48 MST 2010


Kamen Mazdrashki schrieb:
> Hi guys,
> 
> Could someone review&push the attached commits please?

I've pushed 1-6.

in 8 you still use

DRSUAPI_SUPPORTED_EXTENSION_40000000 and
DRSUAPI_SUPPORTED_EXTENSION_80000000

Also you should make almost every symbol in net_drs_bins.c static.
And the casts to info28 and info48 are ugly and would may crash
against a server that returns info24 or info28.

I think it would be better if net_drs_DsBind would construct
a info48 and return that to the caller.

I think we have some similar code in libnet/libnet_become_dc.c

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100205/d2e46d95/attachment.pgp>


More information about the samba-technical mailing list