[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-931-ge13c14e

[Jelmer Vernooij]

Hi Andrew,

Andrew Bartlett wrote:
> The branch, master has been updated
>        via  e13c14e7e440f56069aac6c6568b56e48e7ea825 (commit)
>       from  40017a2143c97c622a3f237f347d2fd3f4039bcc (commit)
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit e13c14e7e440f56069aac6c6568b56e48e7ea825
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Tue Aug 11 18:20:39 2009 +1000
>
>     s4:torture Add test for the NTP signd server
>     
>     This is used by at patch to the NTP project to supply authenticated
>     time as required by MS-SNTP. (ie, to keep windows clients in time sync
>     in the domain)
>     
>     Andrew Bartlett
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  source4/ntp_signd/ntp_signd.c   |    7 +
>  source4/selftest/tests.sh       |    2 +
>  source4/torture/config.mk       |   16 +++
>  source4/torture/ntp/ntp_signd.c |  270 +++++++++++++++++++++++++++++++++++++++
>  source4/torture/torture.c       |    3 +-
>  5 files changed, 297 insertions(+), 1 deletions(-)
>  create mode 100644 source4/torture/ntp/ntp_signd.c
>
>
> Changeset truncated at 500 lines:
>
> diff --git a/source4/ntp_signd/ntp_signd.c b/source4/ntp_signd/ntp_signd.c
> index 4306e5a..6c6416d 100644
> --- a/source4/ntp_signd/ntp_signd.c
> +++ b/source4/ntp_signd/ntp_signd.c
> @@ -153,6 +153,13 @@ static NTSTATUS ntp_signd_recv(void *private_data, DATA_BLOB wrapped_input)
>  		return signing_failure(ntp_signdconn, sign_request.packet_id);
>  	}
>  
> +	/* We need to implement 'check signature' and 'request server
> +	 * to sign' operations at some point */
> +	if (sign_request.version != 1) {
> +		talloc_free(tmp_ctx);
> +		return signing_failure(ntp_signdconn, sign_request.packet_id);
> +	}
> +
>  	domain_sid = samdb_domain_sid(ntp_signdconn->ntp_signd->samdb);
>  	if (!domain_sid) {
>  		talloc_free(tmp_ctx);
> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
> index 6c6a09f..5251791 100755
> --- a/source4/selftest/tests.sh
> +++ b/source4/selftest/tests.sh
> @@ -272,6 +272,8 @@ done
>  
>  plantest "rpc.echo on ncacn_np over smb2" dc $smb4torture ncacn_np:"\$SERVER[smb2]" -U"\$USERNAME"%"\$PASSWORD" -W \$DOMAIN RPC-ECHO "$*"
>  
> +plantest "ntp.signd" dc $smb4torture ncacn_np:"\$SERVER" -U"\$USERNAME"%"\$PASSWORD" -W \$DOMAIN NTP-SIGND "$*" --configfile=st/dc/etc/smb.conf
> +
>   
^^^ Do you really need the server configuration here, or would the
client config also suffice? In the latter case $SMB_CONF_PATH would be
preferable.

Cheers,

Jelmer