[PATCH] s4:pwsettings: Don't assume a value for pwdProperties.

Andrew Kroeger andrew at id10ts.net
Mon Sep 7 01:04:55 MDT 2009


If we cannot retrieve the value, do not assume a particular value.  The fact
that we could not retrieve the value indicates a larger problem that we don't
want to make worse bypossibly clearing bit fields in the pwdProperties
attribute.
---
 source4/setup/pwsettings |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/source4/setup/pwsettings b/source4/setup/pwsettings
index 68ff305..bc65d2c 100755
--- a/source4/setup/pwsettings
+++ b/source4/setup/pwsettings
@@ -84,8 +84,8 @@ except:
 		print "So no settings can be displayed!"
 		sys.exit(1)
 	else:
-		pwd_props = 0
-		message("WARNING: Assuming previous password properties 0 (used for password complexity setting)")
+		print "ERROR: Could not retrieve password properties (used for password complexity setting)"
+		sys.exit(1)
 
 if args[0] == "show":
 	message("Password informations for domain '" + domain_dn + "'")
-- 
1.6.0.6


--------------000702080806020802060003
Content-Type: text/plain;
 name="0004-s4-pwsettings-Added-validation.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="0004-s4-pwsettings-Added-validation.patch"



More information about the samba-technical mailing list