[PATCH] s4: smbcli_transport_send hit the socket right away if possible

Matthias Dieter Wallnöfer mwallnoefer at yahoo.de
Mon Jun 22 13:51:45 GMT 2009


What's with this patch? I integrated it for now in my own repo 
(http://repo.or.cz/w/Samba/mdw.git) but I'm free to discuss about 
changes or reverts. I mention this so the issue shouldn't get completely 
lost.

Matthias

Sam Liddicott schrieb:
> [Metze; "make test" on git master outputs exactly the same test summary
> with our without this patch (apart from the "using seed" lines)]
>
>
> If the transport socket is writable, then push the queue along
> rather than wait until the caller returns back to the tevent loop.
>
> This strategy keeps the sockets piping hot, and is particularly good
> for cases where reading requests from one socket causes lots of
> writes on another socket, or where lots of writes are made in a batch.
>
> It doesn't matter if the socket is not writeable yet, packet_queue_run
> will return quite cheaply in such a case.
>
> Signed-off-by: Sam Liddicott <sam at liddicott.com>
> ---
>  source4/libcli/raw/clitransport.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
>   




More information about the samba-technical mailing list