[PATCH] added missing '\n' to ldb_debug messages

[simo]

On Fri, 2009-07-10 at 22:55 +0200, Sumit Bose wrote:
> On Fri, Jul 10, 2009 at 07:45:05AM -0400, simo wrote:
> > On Fri, 2009-07-10 at 08:54 +0200, Sumit Bose wrote:
> > > On Fri, Jul 10, 2009 at 11:52:24AM +1000, Andrew Bartlett wrote:
> > > > On Thu, 2009-07-09 at 17:23 +0200, Sumit Bose wrote:
> > > > > Hi,
> > > > > 
> > > > > this patch adds a few missing '\n' to ldb debug messages to make the
> > > > > debug experience more consistent.
> > > > 
> > > > I would rather the reverse - that we never specify the \n.
> > > > 
> > > > The inclusion of \n in Samba's DEBUG() messages is a hack dating back
> > > > years, to do with the way Samba outputs multiple line messages.  I don't
> > > > think we need to infect ldb with that.
> > > > 
> > > > Instead, ldb_debug_stderr() should be patched to output a \n on the end
> > > > of the line, as the log format requires.  (This message can be
> > > > redirected, and may not go to a log, and so should not have the log
> > > > formatting oddity embeded in the code).
> > > > 
> > > 
> > > I have talked with Simo on irc and got the impression that he preferred
> > > having \n. In general I don't mind which way to go as long as it is only
> > > one way.
> > > 
> > > If we agree on having no \n at all, I can send a new patch. Simo?
> > 
> > Yes I am fine either way too, if Andrew feels strongly for no \n, that
> > ok with me.
> > 
> 
> ok, this new patch removes all \n and adds one in ldb_debug_stderr().

Thanks!
Pushed to master.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>