[PATCH] Remove dependency from libintl in Samba4.

Jelmer Vernooij jelmer at samba.org
Sun Jul 5 17:36:00 GMT 2009


Timur I. Bakeyev wrote:
> 2009/6/17 Jelmer Vernooij <jelmer at samba.org>:
>   
>> Timur I. Bakeyev wrote:
>>     
>>> On Mon, Jun 08, 2009 at 09:27:30AM +1000, Andrew Bartlett wrote:
>>> And here we are comming to the most interesting part.
>>>
>>> # find source4 -name \*.po
>>>
>>> Gives NO results. There are just simply no PO files. Moreover,
>>> distribution of the Heimdal 1.2.1 doesn't have them either! Neither
>>> does it have --with-nls flag to the configure. Nor it has any
>>> references to the libintl anywhere, besides few files which were
>>> generated by bison and have HAVE_LIBINTL conditional include.
>>>
>>> So, to me it seems that the whole addition of the libintl was a
>>> mistake in a first place, caused by quick look through the code and
>>> noticeing HAVE_LIBINTL condition. But it has no use and is
>>> automatically added by bison to all generated files.
>>>       
>> We should talk to upstream Heimdal about this and either including po
>> files there or removing libintl support. It's indeed pointless to link
>> against libintl without any actual translations :-)
>>     
>
> Well, my point here is that upstream doesn't link against libintl in
> the first place. So where that libintl comes to Samba4 code is hard to
> say.
>   
Upstream does link to libintl. From its configure:

dnl check for libintl
rk_TEST_PACKAGE(libintl,
[#include <libintl.h>],
[-lintl],,,LIBINTL)

And it contains .po files, albeit only for Swedish:

./po/heim_com_err-1765328384/sv_SE.po
./po/heimdal_kuser/sv_SE.po
./po/heimdal_krb5/sv_SE.po

> And, to stress it again - I'd really love to have ability to no to
> link against optional libraries.
>   
Patches to have a flag for explicitly configure whether or not to use
libintl are very much welcome.

Cheers,

Jelmer


More information about the samba-technical mailing list