[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-1097-gcf7539a

Jeremy Allison jra at samba.org
Mon Feb 23 14:23:56 MST 2009


On Mon, Feb 23, 2009 at 12:50:53PM -0600, Derrell Lipman wrote:
> The branch, master has been updated
>        via  cf7539abfb0f6e6956bed7a478e0cda6ab734674 (commit)
>       from  ca24822234d9dc77dbe3f351d6dbab5558efac39 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit cf7539abfb0f6e6956bed7a478e0cda6ab734674
> Author: Derrell Lipman <derrell.lipman at unwireduniverse.com>
> Date:   Mon Feb 23 13:50:11 2009 -0500
> 
>     Make char* parameters const
>     
>     - Use const in function signatures whenever appropriate, to help prevent
>       errant scribbling on users' buffers. smbc_set_credentials() always acted as
>       if its formal parameters were const char *, and changing the formal
>       declaration to specify that should not cause any change to the ABI. It is
>       still allowable to pass a writable buffer to a function which specifies that
>       it will not write to the buffer.
>     
>       I'm making this change only in master.

Derrell, I think this change needs to be in 3.3 also (IMHO).

Jeremy.


More information about the samba-technical mailing list