[SCM] Samba Shared Repository - branch master updated -
release-4-0-0alpha7-1034-g786447d
Volker Lendecke
Volker.Lendecke at SerNet.DE
Tue Apr 14 06:00:43 GMT 2009
On Tue, Apr 14, 2009 at 03:55:13PM +1000, Andrew Bartlett wrote:
> > On Mon, Apr 13, 2009 at 11:05:16PM -0500, Andrew Bartlett wrote:
> > > - if (!push_ucs2_allocate(&buffer, src, &size)) {
> > > + if (!push_ucs2_talloc(NULL, &buffer, src, &size)) {
> >
> > Any reason why you don't use talloc_tos() in your patches?
> > Is there any flaw with talloc_stack.c that I should know
> > about?
>
> I did, in most of the places where it seemed reasonable (such as was
> indicated by similar use in that context). The rest I just did the most
> simple replacement possible, to avoid introducing inadvertent errors.
So, what's the bug that you fear by s/NULL/talloc_tos()/?
This *should* be idempotent but faster in smbd use.
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090414/9571fbee/attachment.bin
More information about the samba-technical
mailing list