[PATCH] About commit pam_winbind: translate some more string.

boyang boyang at suse.de
Sun Nov 16 09:00:10 GMT 2008


Hi, gd:
     I am sorry that I am unaware of that you were asking me. :-)
     I think there is a problem in the commit.
     master:        540b2df874ff053bccd6ef6165476d5225f2ae16
     v3-3-test:     3310deac11bb579ba364dabd59e149fdd68360ed
The reason here is that:
     N_(string1)
     N_(string2)
will cause xgettext to extract two msgid --- string1 and string2, and
then put it into .po, then .mo. look it in ntstatus_erros[].
     N_("Your account has been locked. ")
     N_("Please contact your System administrator")
But in _get_ntstatus_error_string(), we use dgettext("string1string2",
domain). which means that dgettext will search .mo for msgid
"string1string2", which is never exist in .mo. :-) That will cause the
i18n/l10n failed, and display the original english message.
     Patches are in the attachment for master and v3-3-test, please
review them. Thanks!
    
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v1-i18n-l10n-master.diff
Type: text/x-patch
Size: 1323 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081116/84302d1a/v1-i18n-l10n-master.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v1-i18n-l10n-v3-3-test.diff
Type: text/x-patch
Size: 1319 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081116/84302d1a/v1-i18n-l10n-v3-3-test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081116/84302d1a/boyang.vcf


More information about the samba-technical mailing list