str_list_make in master

[Dan Sledz]

It appears the behavior of str_list_make changed between samba 3.2 and
master.

In samba 3.2 passing NULL or an empty string returned NULL.

In master, it now returns a list of length 1 with the first string set
to NULL (an empty list)

 

In our smb.conf,  we use "valid users = " to imply that everyone has
access to a share.  The new behavior now causes user_ok_token() to deny
everyone.  As a workaround, I've stopped setting "valid users", but it's
concerning that I'm unable to express the default value in smb.conf.

 

Should the callers adjust or should str_list_make change?