[PATCH] fix for ldb_msg_add_string() to increase value lifetime

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Sep 3 11:46:06 GMT 2007


On Mon, Sep 03, 2007 at 09:35:29PM +1000, Tim Potter wrote:
> Hey ldb people - I would like to propose this patch to take a copy of
> the string value when calling ldb_msg_add_string().  It's actually
> pretty easy to find garbage in your attribute values if the lifetime of
> the const char *str parameter is less than the lifetime of the
> ldb_message.
> 
> Comments?  It looks OK to me.  (-:

Why don't you just check it in?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070903/baa9227b/attachment.bin


More information about the samba-technical mailing list