[PATCH] Fix two type-punned warnings

Jeremy Allison jra at samba.org
Sun Oct 21 01:52:38 GMT 2007


On Sat, Oct 20, 2007 at 04:24:46PM +0200, Volker Lendecke wrote:
> ---
>  source/param/loadparm.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/source/param/loadparm.c b/source/param/loadparm.c
> index 80462ee..e7e7b8c 100644
> --- a/source/param/loadparm.c
> +++ b/source/param/loadparm.c
> @@ -227,7 +227,7 @@ typedef struct {
>  	bool bDisableSpoolss;
>  	int syslog;
>  	int os_level;
> -	int enhanced_browsing;
> +	bool enhanced_browsing;
>  	int max_ttl;
>  	int max_wins_ttl;
>  	int min_wins_ttl;
> @@ -1589,7 +1589,7 @@ static void init_globals(bool first_time_only)
>  
>  	Globals.map_to_guest = 0;	/* By Default, "Never" */
>  	Globals.oplock_break_wait_time = 0;	/* By Default, 0 msecs. */
> -	Globals.enhanced_browsing = True; 
> +	Globals.enhanced_browsing = true; 
>  	Globals.iLockSpinTime = WINDOWS_MINIMUM_LOCK_TIMEOUT_MS; /* msec. */
>  #ifdef MMAP_BLACKLIST
>  	Globals.bUseMmap = False;
> @@ -2018,7 +2018,7 @@ FN_GLOBAL_BOOL(lp_paranoid_server_security, &Globals.paranoid_server_security)
>  FN_GLOBAL_INTEGER(lp_maxdisksize, &Globals.maxdisksize)
>  FN_GLOBAL_INTEGER(lp_lpqcachetime, &Globals.lpqcachetime)
>  FN_GLOBAL_INTEGER(lp_max_smbd_processes, &Globals.iMaxSmbdProcesses)
> -FN_GLOBAL_INTEGER(_lp_disable_spoolss, &Globals.bDisableSpoolss)
> +FN_GLOBAL_BOOL(_lp_disable_spoolss, &Globals.bDisableSpoolss)
>  FN_GLOBAL_INTEGER(lp_syslog, &Globals.syslog)
>  static FN_GLOBAL_INTEGER(lp_announce_as, &Globals.announce_as)
>  FN_GLOBAL_INTEGER(lp_lm_announce, &Globals.lm_announce)

Looks good to me. Can you push please ?

Jeremy.


More information about the samba-technical mailing list