svn commit: samba r25495 - in branches: SAMBA_3_2/source/lib/replace/system SAMBA_3_2_0/source/lib/replace/system

simo idra at samba.org
Thu Oct 4 00:54:31 GMT 2007


On Thu, 2007-10-04 at 01:21 +0200, Henrik Nordstrom wrote:
> On ons, 2007-10-03 at 15:35 -0700, Jeremy Allison wrote:
> 
> > I don't think we need to go that far - let's just watch the
> > build farm and switch to a test for sockaddr_in6 if we need to.
> 
> Will the build farm notice? sockaddr_storage is only used for
> allocations/storage, right? All uses is casted to the protocol specific
> sockaddr_xx which silences any compiler warnings... so you'll end up
> with some interesting memory corruption if ipv6 is enabled without
> sockaddr_storage.
> 

This was my fear as well.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-technical mailing list