Showstopper in winbindd: 3.0.25pre2 on hold for a few hours

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerald (Jerry) Carter wrote:

> I've got a local tree for Centeris that I pulled in the upstream
> SAMBA_3_0 tree yesterday and now winbindd is reporting strange
> things via the getpwnam() call.  But it could be my local
> changes.  I'm not sure yet.  But the code in my local tree is
> close enough to the SAMBA_3_0_25 tree that it warrants a
> shoirt investigation to make sure the pull from the Samba
> tree didn't introduce a regression.
> 
> The symptom is that wbinfo -i "ad\jerry" should report:
> 
>   AD\jerry:*:100000:100000:Jerry Carter:/data/home/AD/jerry:/bin/bash
> 
> But instead I get
> 
>   VALE\:*:100000:0::/home/local/VALE/:/bin/bash
> 
> Where VALE is a trusted Samba domain and AD is a Windows 2003
> domain.
> 
> Just give me a couple hours to confirm or disprove the bug
> in the Samba tree and we'll be back onto release ASAP.


False alarm.  The bug is only in the SAMBA_3_0 tree.

James, I think this one is yours:

find_domain_from_sid_noinit():

  if (sid_peek_check_rid(&domain->sid, sid, &discard) == 0) {


sid_peek_check_rid() returns a BOOL :-)




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGAW3PIR7qMdg1EfYRAoS+AKCH/3QC0Folp/Zmzb3vkYUQvktamQCfYtuC
nHFycE4bEMSzxp6JEtRdK+4=
=AnQ9
-----END PGP SIGNATURE-----