svn commit: samba r19011 -
in branches/SAMBA_3_0/source/lib/replace: .
Stefan (metze) Metzmacher
metze at samba.org
Sun Oct 1 18:13:27 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> }
> + if (fstat(d->fd, &sb) < 0) {
> + close(d->fd);
> + free(d);
> + return NULL;
> + }
> + if (!S_ISDIR(sb.st_mode)) {
> + close(d->fd);
> + free(d);
> + errno = ENOTDIR;
> + return NULL;
> + }
Yes, please! (but first cleanup the whitespaces into tabs:-)
We should also add a test for this in the libreplace testsuite
to make sure that every opendir() gives this error.
metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFFIAVHm70gjA5TCD8RAvMQAKCW4MrEabRdSldOh8VtkiWCX78x8ACdEoez
bqSBIscrXIOu/lgILFE5YMw=
=krL4
-----END PGP SIGNATURE-----
More information about the samba-technical
mailing list