Remove functions from SAMBA_VERSION_STRING

[Andrew Bartlett]

On Thu, 2006-05-04 at 09:39 +1000, James Peach wrote:
> On Wed, 2006-05-03 at 06:57 -0500, Gerald (Jerry) Carter wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Andrew Bartlett wrote:
> > 
> > > I would like to remove the ability to use C functions, and 
> > > instead bring it back to a simple macro.  This ensures that
> > > we never allocate in the fault code (as a C function in
> > > this location would probably have to allocate it's return value).
> 
> we have to allocate to print a stack trace

Samba4 does this without allocation.  (Just using a lot of stack)

> > > As version strings should never change at runtime, any more
> > > complex expressions could be included in a script to generate
> > > VERSION, if required.
> > > 
> > > SAMBA_VERSION_STRING could then return to being a constant string.
> > > 
> > > Any objections?  Metze wants this in sync between Samba3 and Samba4
> > 
> > I've never used it.  If metze wants to remove it, them
> > that's fine with me since it was his code to begin with IIRC.
> > 
> > James, Lars?  Have you guys ever used it for packaging?
> 
> My packaging build includes a patch that sets
> SAMBA_VERSION_VENDOR_SUFFIX to a string literal. Having some way to flag
> that smbd is a vendor version is necessary, but I don't mind what it is.
> I don't need any function calls for this.

Great.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060504/6641e470/attachment.bin