Remove functions from SAMBA_VERSION_STRING

Gerald (Jerry) Carter jerry at samba.org
Wed May 3 11:57:56 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett wrote:

> I would like to remove the ability to use C functions, and 
> instead bring it back to a simple macro.  This ensures that
> we never allocate in the fault code (as a C function in
> this location would probably have to allocate it's return value).
> As version strings should never change at runtime, any more
> complex expressions could be included in a script to generate
> VERSION, if required.
> 
> SAMBA_VERSION_STRING could then return to being a constant string.
> 
> Any objections?  Metze wants this in sync between Samba3 and Samba4

I've never used it.  If metze wants to remove it, them
that's fine with me since it was his code to begin with IIRC.

James, Lars?  Have you guys ever used it for packaging?




cheers, jerry
=====================================================================
I live in a Reply-to-All world.               -----------------------
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEWJrEIR7qMdg1EfYRAvc0AKC4KkWh8drvH1xBoPCOoSUQrn1jXwCg6sOA
2LKgd1+iNdN5cnXTvJiiJX8=
=G2Sl
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list