ideas for supporting long smb.conf variables?

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerald (Jerry) Carter wrote:

> I decided to go with %(...) since that fits easily with the current
> convention of %[A-z] and %$(...).    A preliminary patch is attached.
> 
> The patch addresses several issues that were raised:
> 
> * provides a framework for %(....) long variable names
> * adds support for the %(DomainSID) which can be used in
>   'write list', 'read list', & 'admin users'
> * replaces the standard_sub_XXX() functions with wrappers
>   around the alloc_sub_xxx() counterparts in order to remove
>   the duplicated code.
> 

Volker's comments from #samba-technical are

* use nt_token_check_sid() instead of opcying
  is_sid_in_token() from net_rpc.c
* perhaps consider passing down a TALLOC_CTX to the longvar_table
  function (which I agree is a good and idea and will work on
  cleaning up as things move forward).

So with that it's going into the tree.





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEEEj9IR7qMdg1EfYRAv4pAJ9i1TfhjWmHsYRQi+F7oJQdSMn9twCfYeJU
fwca5DkvkoGshOv8+0wMYyA=
=F8jU
-----END PGP SIGNATURE-----