[PATCH][SAMBA4] fix inconsistent config summary output
James Peach
jpeach at sgi.com
Wed Apr 5 22:57:44 GMT 2006
On Wed, 5 Apr 2006 07:43 pm, Stefan (metze) Metzmacher wrote:
> James Peach schrieb:
> Hi James,
>
> > AC_MSG_CHECKING(whether to use pthreads)
> > +SMB_EXT_LIB(PTHREAD,[-lpthread])
> > +SMB_EXT_LIB_ENABLE(PTHREAD,NO)
> > +
> > AC_ARG_WITH(pthreads,
> > [ --with-pthreads Include pthreads (default=no) ],
> > [ case "$withval" in
> > @@ -23,8 +26,6 @@
> > AC_MSG_RESULT(no)
> > )
> >
> > -SMB_EXT_LIB(PTHREAD,[-lpthread])
> > -
>
> this is not needed as external libs with SMB_EXT_LIB() are off by default
Yep. I was trying to get it to emit $enabled{EXT_LIB_PTHREAD} = "NO". I
missed reverting this file when I made the patch.
> > AC_MSG_CHECKING(whether to search for setproctitle support)
> > AC_ARG_WITH(setproctitle,
> > [ --with-setproctitle Search for setproctitle support (default=no)],
> > Index: build/smb_build/summary.pm
> > ===================================================================
> > --- build/smb_build/summary.pm (revision 14915)
> > +++ build/smb_build/summary.pm (working copy)
> > @@ -7,6 +7,13 @@
> > package summary;
> > use strict;
> >
> > +sub enabled($)
> > +{
> > + my ($val) = @_;
> > +
> > + return (defined($val) && $val =~ m/yes|true/i);
>
> does this catch "YES" and "yes"?
Yup. It catches any case variation of "yes" or "true".
> if so please commit the changes to this file
ok, will do
--
James Peach | jpeach at sgi.com | SGI Australian Software Group
I don't speak for SGI.
More information about the samba-technical
mailing list