Samba 4 libnet_join and RPC-JOIN torture test
Stefan Metzmacher
metze at samba.org
Mon Sep 12 06:02:21 GMT 2005
Am Montag, 12. September 2005 02:22 schrieb Brad Henry:
> + if (!lsa_open_policy.in.system_name) {
> + r->out.error_string = NULL;
> + talloc_free(tmp_ctx);
> + return NT_STATUS_NO_MEMORY;
> + }
please use if (!lsa_open_policy.in.system_name) goto no_mem;
in all places, as you missed sometimes the talloc_free(tmp_ctx),
only when creating the tmp_ctx fails use this
> + if (!ltmp_ctx) {
> + r->out.error_string = NULL;
> + return NT_STATUS_NO_MEMORY;
> + }
please take care of only use 8 char tabs, and _NO_ whitespaces,
likt here:
+ if (!tmp_ctx) {
+ libnet_r->out.error_string = NULL;
+ return NT_STATUS_NO_MEMORY;
+ }
BTW: your patches start looking better:-)
--
metze
--
Stefan (metze) Metzmcher <metze at samba dot org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20050912/1f91a376/attachment.bin
More information about the samba-technical
mailing list