svn commit: samba r7025 - in branches/SAMBA_3_0/source: lib tdb

[Jeremy Allison]

On Fri, May 27, 2005 at 02:53:42PM -0400, derrell at samba.org wrote:
> Jeremy Allison <jra at samba.org> writes:
> 
> > How about this as a patch instead ?
> 
> This is fine.  I was under the impression that the low-level function
> read_socket_data() had semantics that were depended upon, so I hadn't wanted
> to muck with it.  If it is allowed to loop upon being interrupted by a signal,
> this is a much simpler and preferable patch.

It does have semantics that are depended upon. Unfortunately the semantics
that are being depended on are the ones I described :-), ie. never returning
less than N bytes :-). So we need to fix it so that it has those semantics :-).

> > The only thing we'd need to add is
> > an abort after XX times around the loop so stop us getting stuck forever
> > on a socket returning EAGAIN.
> 
> I'll implement it as a max of MAX_INTERRUPTS (e.g. #define MAX_INTERRUPTS 10)
> interrupts.  MAX_INTERRUPTS can be manipulated as required.

Looks fine by me - do you want me to do it ?

Jeremy.