svn commit: samba r12432 - in branches/SAMBA_4_0/source/rpc_server/samr: .

[Andrew Bartlett]

On Thu, 2005-12-22 at 13:00 +0100, Volker Lendecke wrote:
> On Thu, Dec 22, 2005 at 11:26:13AM +0000, abartlet at samba.org wrote:
> > Log:
> > Re-indent and consistantly cancel the transaction.
> 
> Isn't that a classical case for a talloc destructor?

Indeed, and it raises a good point.  

I think the ldb_transaction call should take a talloc context, on which
is should add it's own internal destructor.  While a transaction is
rolled back on database close, in this case that would be too long.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20051222/e0eba994/attachment.bin