net ads testjoin issue after date change on the server!

[Ephi Dror]

Hi Jerry,

I found out that the problem is in rb5_error_code ads_krb5_mk_req()

There is a while loop that to my opinion we never get out of it due to
the fact that the date was advanced beyond the ticket granted and the
kerberos I use doesn't support krb5_cc_remove_cred().

Here is debug level 1 trace:

bash-2.05b# net ads testjoin -d 1
[2006/08/19 19:04:22, 1, pid=14681]
lib/util_unistr.c:load_case_tables(78)
  creating lame lowcase table
[2006/08/19 19:04:22, 1, pid=14681]
libsmb/clikrb5.c:ads_cleanup_expired_creds(339)
  ads_cleanup_expired_creds: krb5_cc_remove_cred failed, err Ccache
function not supported: not implemented
[2006/08/19 19:04:22, 1, pid=14681]
libsmb/clikrb5.c:ads_cleanup_expired_creds(339)
  ads_cleanup_expired_creds: krb5_cc_remove_cred failed, err Ccache
function not supported: not implemented
[2006/08/19 19:04:22, 1, pid=14681]
libsmb/clikrb5.c:ads_cleanup_expired_creds(339)
  ads_cleanup_expired_creds: krb5_cc_remove_cred failed, err Ccache
function not supported: not implemented
[2006/08/19 19:04:22, 1, pid=14681]
libsmb/clikrb5.c:ads_cleanup_expired_creds(339)
  ads_cleanup_expired_creds: krb5_cc_remove_cred failed, err Ccache
function not supported: not implemented
[2006/08/19 19:04:22, 1, pid=14681]
libsmb/clikrb5.c:ads_cleanup_expired_creds(339)
  ads_cleanup_expired_creds: krb5_cc_remove_cred failed, err Ccache
function not supported: not implemented
 
          < and continue for ever >

My question is: why in libsm/clikrb5.c line 340
The code says:
		/* If we have an error in this, we want to display it,
		   but continue as though we deleted it */

And returns True?

This makes the code calling krb5_get_credentials() in line 386 again and
the loop never end.

Any thoughts? At least, maybe if the error is "not supported: not
implemented" we should return False?

Cheers,
Ephi


-----Original Message-----
From: Gerald (Jerry) Carter [mailto:jerry at samba.org] 
Sent: Tuesday, August 16, 2005 8:50 AM
To: Ephi Dror
Cc: Jeremy Allison; samba-technical at lists.samba.org
Subject: Re: net ads testjoin issue after date change on the server!

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ephi Dror wrote:
> Hi Jeremy,
> 
> Here are more info:
> 
> 1. Changing date to any date in the past (30 years or so..) or any 
> date within this year, it works fine.
> 2. Changing date to next year (2006  and up) causing the problem.
> 3. It takes about 5 minutes until segmentation fault shows up. During 
> that time, the entire server behaves very slow, VmData increases and 
> increases until it reaches about 4054368K and then segmentation fault 
> happened.
> 4. Control-C doesn't help
> 
> Here is the last snapshot I took while running "net ads testjoin"
> [root at h-00d06806ef33 root]# grep Vm /proc/22270/status
> VmSize:  4062716 kB
> VmLck:         0 kB
> VmRSS:   2013176 kB
> VmData:  4054368 kB
> VmStk:       144 kB
> VmExe:      1984 kB
> VmLib:      5948 kB
> 
> Watching memory sizes was showing that VmSize and VmData were 
> increasing slowly while VmRSS stayed at about the same.

I'd try running it under valgrind.  I'll bet thgere's a memory leak in
the krb5 libs.





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDAgsKIR7qMdg1EfYRAs7eAKCo57FWS0l2y4A8Sv+cqwhlW/XD3ACggxK3
Y3RSG6RCkLzc2ovdin7r7E0=
=Zp9s
-----END PGP SIGNATURE-----