SSVAL misuse in cmd_spoolss.c?

[daniel.jarboe at custserv.com]

In cmd_spoolss.c:

info->dependentfiles[i] = SSVAL(&info->dependentfiles[i], 0, str2[i]);

I believe this assignment shouldn't be taking place, and it is unlike
other usages of SSVAL throughout the code.  This line is in both samba
2.2.8a and 3.0.0.  The assignment affects s390 platforms (maybe
others?), causing rpcclient adddriver dependentfiles to be filled with
nulls.  See bug #501.  Taking out the assignment did not break intel,
and fixed the problem for s390.  Patch attached.

Thanks,
Daniel Jarboe









-----------------------------------------------------------------------

This message is the property of Time Inc. or its affiliates. It may be
legally privileged and/or confidential and is intended only for the use
of the addressee(s). No addressee should forward, print, copy, or
otherwise reproduce this message in any manner that would allow it to be
viewed by any individual not originally listed as a recipient. If the
reader of this message is not the intended recipient, you are hereby
notified that any unauthorized disclosure, dissemination, distribution,
copying or the taking of any action in reliance on the information
herein is strictly prohibited. If you have received this communication
in error, please immediately notify the sender and delete this message.
Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmd_spoolss.patch
Type: application/octet-stream
Size: 489 bytes
Desc: cmd_spoolss.patch
Url : http://lists.samba.org/archive/samba-technical/attachments/20031020/41920fcf/cmd_spoolss.obj