free_auth_context() in smbd/auth.c never frees its auth_methods list

Andrew Bartlett abartlet at samba.org
Wed Nov 12 22:36:41 GMT 2003


On Thu, 2003-11-13 at 04:42, Emil Rasamat wrote:
> Can anyone give me a clue why does free_auth_context() in smbd/auth.c
> never free its auth_methods list? AFAICS methods and their private data
> remain in memory.
> Emil Rasamat, Disksites.

I guess I never ran it under valgrind with a backend that used the
private data.  Now, you should use the talloc context if possible (which
the talloc_destroy() will free()), but for things like an connection to
a socket (like security=server does) this is indeed quite valid...

File a bug on bugzilla.samba.org - bonus points for including a patch. 
Assign it to me.

Thanks for picking it up!

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20031113/22b2b3c2/attachment.bin


More information about the samba-technical mailing list