[PATCH] fix: id_sid cache
Stefan (metze) Metzmacher
metze at metzemix.de
Tue Mar 4 06:28:21 GMT 2003
At 18:03 02.03.2003 +0000, jra at dp.samba.org wrote:
>On Wed, Feb 26, 2003 at 03:55:49PM +0100, Stefan (metze) Metzmacher wrote:
> > Hi Jeremy,
> >
> > I have a little fix for the id_sid cache, to correct return the sidtype.
>
>Hi Stefan,
>
> Actually there isn't any point in returning the sidtype
>here that I can see. We're only after the uid_t or gid_t in these
>calls.
>
>I considered this when I re-wrote the code, but already decided
>it wasn't needed.
Ok, but we didn't need to cache the sidtype at all in this case!
And we also didn't need a sidtype parameter in this funtions at all.
But if we decide to have the sidtype stuff, it have to work correct and the
current code,
without my little fix, is incorrect!
It didn't set the *sidtype at all in the sid_to_*id() fn's!
metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de>
More information about the samba-technical
mailing list