[PATCH] example/VFS ....confiure.in...

[Stefan (metze) Metzmacher]

At 13:13 24.06.2003 +0300, Alexander Bokovoy wrote:
>On Tue, Jun 24, 2003 at 12:09:00PM +0200, Stefan (metze) Metzmacher wrote:
> > >> and parsing this string is the best thing we can do for dealing with
> > >samba
> > >> 2.2.* and 3.0aplha* and 3.0.0beta1
> > >Why you need to parse that at all?
> >
> > samba-vscan is using macros like:
> >
> > #if (SAMBA_VERSION_MOJOR==3)
> >
> > ...
> > to able to compile with all samba 2.2.* and 3.0aplha* and 3.0.0beta1
> > releases
> >
> > and the user had to modifiy the header file manually each time.
> >
> > so I added a configure.in test for it which automaticly detect the samba
> > version
> > and set SAMBA_VERSION_MAJOR SAMBA_VERSION_MINOR SAMBA_VERSION_RELEASE
> > SAMBA_VERSION_BETA_RELEASE SAMBA_VERSION_ALPHA_RELEASE ...
> >
> > this is maybe usefull for other module writers too.
>That means it is really better to provide those defines in version.h as
>numbers not strings. Would it solve your problem for 3.0?

yep

>For 2.2 and 3.0a/b1 I would propose to use identification method based on
>VFS versions -- as it is done in drweb-vfs for Samba.

that's basicly what I've done but there are changes in samba while a 
SMB_VFS_INTERAFCE_VERSION didn't change:

and sometimes we need to catch these too...



metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de>