libcli fix is wrong
Stefan (metze) Metzmacher
metze at metzemix.de
Fri Aug 15 22:31:37 GMT 2003
Hi Herb,
void cli_shutdown(struct cli_state *cli)
{
- if (!cli) return;
+ if (!cli || !cli->tree) return;
cli->tree->reference_count++;
cli_tree_close(cli->tree);
if (cli->mem_ctx) {
this is wrong as don't run talloc_destroy() anymoreif cli->tree == NULL
it should be
if (!cli) return;
if (cli->tree) {
cli->tree->reference_count++;
cli_tree_close(cli->tree);
}
if (cli->mem_ctx) {
talloc_destroy(cli->mem_ctx);
}
metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de>
More information about the samba-technical
mailing list