[PATCH] updates for examples/VFS/*
Stefan (metze) Metzmacher
metze at metzemix.de
Sun Aug 10 13:22:11 GMT 2003
At 15:12 10.08.2003 +0200, Jelmer Vernooij wrote:
>Hi Stefan!
>
> > here's my patch for examples/VFS/*
>Looks good! I have some small comments.
>
> > 1) configure autodetect the samba version from include/version.h
> > this can be overwritten with configure --with-samba-version="3.0.0rc1cvs"
> > for vendors which changed include/version.h
> >
> > there
> > SAMBA_VERSION_MAJOR
> > SAMBA_VERSION_MINOR
> > SAMBA_VERSION_REALEASE
> > ...
> > macros is module_config.h defined then
>There is a lot of code duplication between aclocal.m4 in the VFS
>directory and source/.
Yes, that's because I want module writers be independent of the samba source
during autogen.sh
And I think that's ok...
> > 2) I add a skel_compat module which compiles on 2.2.* and 3.0.*
>This one looks kinda confusing to me - have you asked Alexander's
>opinion on this one?
Alexander,
have you comments on the skel_compat module?
> > 3) the skel_* modules include module_config.h (which holds SAMBA_VERSION_*
> > defines) now
> > and I add the skel_sendfile function which were missing
> >
> > Enjoy your flight!:-)
>Thanks! Only 6 hours before we arrive in San Francisco.
:-)
metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de>
More information about the samba-technical
mailing list