strupper() on username and domain in cli_session_setup_nt1()?

[abartlet at dp.samba.org]

On Mon, Sep 23, 2002 at 08:30:28AM -0500, Gerald Carter wrote:
> On Mon, 23 Sep 2002, Tim Potter wrote:
> 
> > I'm just wondering whether it is strictly necessary to uppercase the
> > username and domain name when performing a session setup.  Applying the
> > following patch should not break anything and would make smbclient be
> > able to test for case sensitivity bugs in the remote server.
> > 
> > The behaviour of uppercasing everything seems to be peculiar to Windows
> > 9x.  According to some testing done by the HP guys and girls, NT and
> > 2000 send across the case of the username as it was created in the SAM,
> > whereas XP sends the case the user logged in with.
> 
> The patch looks fine to me Tim.  

Makes sense to me - particularly when the remote server is a samba box
with an InterCase username.

Andrew Bartlett