[PATCH] group control bits ....

Kai Krueger kai at kruegernetz.de
Thu Sep 5 21:24:00 GMT 2002


----- Original Message -----
From: "Stefan (metze) Metzmacher" <metze at metzemix.de>
To: "Jelmer Vernooij" <jelmer at samba.org>; "Andrew Bartlett"
<abartlet at samba.org>; "Kai Krueger" <kai at kruegernetz.de>
Cc: <samba-technical at lists.samba.org>
Sent: Thursday, September 05, 2002 7:39 PM
Subject: [PATCH] group control bits ....

...

> diff -Npur --exclude=CVS --exclude=*.bak --exclude=*.o --exclude=.#*
HEAD/examples/sam/sam_skel.c HEAD-fix/examples/sam/sam_skel.c
> --- HEAD/examples/sam/sam_skel.c Sat Aug 31 15:36:26 2002
> +++ HEAD-fix/examples/sam/sam_skel.c Thu Sep  5 19:37:18 2002
> @@ -183,7 +183,7 @@ NTSTATUS sam_skel_enum_groupmembers(cons
>  }
>
>
> -NTSTATUS sam_skel_get_groups_of_account(const struct sam_methods
*sam_method, const SAM_ACCOUNT_HANDLE *account, const uint32 type, uint32
*group_count, SAM_GROUP_ENUM **groups)
> +NTSTATUS sam_skel_get_groups_of_sid(const struct sam_methods *sam_method,
const NT_USER_TOKEN *access_token, const DOM_SID **sids, const uint32 type,
uint32 *group_count, SAM_GROUP_ENUM **groups)

you forgott to change the const uint32 type to uint16 group_ctrl

>  {
>   DEBUG(0,("sam_skel: %s was called!\n",__FUNCTION__));
>   return NT_STATUS_NOT_IMPLEMENTED;
> @@ -238,7 +238,7 @@ NTSTATUS sam_init(const SAM_CONTEXT *sam
>   (*sam_method)->sam_delete_member_from_group =
sam_skel_delete_member_from_group;
>   (*sam_method)->sam_enum_groupmembers = sam_skel_enum_groupmembers;
>
> - (*sam_method)->sam_get_groups_of_account =
sam_skel_get_groups_of_account;
> + (*sam_method)->sam_get_groups_of_sid = sam_skel_get_groups_of_sid;
>
>   (*sam_method)->free_private_data = NULL;
>
>

Other than that, I think the patch is good and imho should be checked in if
it compiles.

Kai




More information about the samba-technical mailing list