use sendfile loadparm.c / docs inconsistency

[jra at dp.samba.org]

On Thu, Oct 10, 2002 at 01:32:29PM -0700, Pierre Belanger wrote:
> Hi,
> 
> [ Yeah, me again about this sendfile stuff ;-) ]
> 
> I notice some inconsistence in the documentations...
> 
> "smb.conf.5" is listing "use sendfile" in the
> 
>   "COMPLETE LIST OF GLOBAL PARAMETERS"
> 
> area, and later in the same manual, it shows
> "use sendfile" has a "shared parameter":
> 
>   "use sendfile (S)"
> 
> I think this parameter should be moved from
> the "COMPLETE LIST OF GLOBAL PARAMETERS" to
> "COMPLETE LIST OF SERVICE PARAMATERS".

Ok - will do.

> I also notice in param/loadparm.c :
> 
> {"use sendfile", P_BOOL, P_LOCAL,
> &sDefault.bUseSendfile, NULL, NULL, FLAG_SHARE},
> 
> ps: Is there really a need to control "use sendfile"
>     per share? I don't see one, if sendfile is working
>     why not turn it on... that's my opinion!

Yes there is. If you don't have kernel oplocks you
might want to only enable it for read-only shares for
example.

Thanks,

	Jeremy.