tdb corruption with "use mmap=false"

[Jeremy Allison]

"MCCALL,DON (HP-USA,ex1)" wrote:
> 
> Hi Jeremy,
> I pulled the patch; and it will probably 'fix' reinout's problem with lotus
> notes, BUT - if I'm reading this right, if the offset (not the count) is >
> 31 bits, we return success, but never actually try the fcntl lock.
> Isn't this going to be a problem when we are really counting on an fcntl
> lock on the file?  What am I missing?

No this isn't a problem. If the underlying NFS mount cannot
support locks with a start offset of >31 bitsthen we cannot
try the lock - it will fail. But by the same token, as such
a lock cannot exist on that filesystem then other processes
can never see or conflict with such a lock (by definition
it can't exist). So just pretending it worked w.r.t. the
64 bit unsigned Windows clients is correct. This is the
same thing we do when simulating 64 bit unsigned locks on
a local filesystem with 31 bit signed posix locks. The
only difference is that because of the dynamic nature
of NFS mounts we need to deal with this at runtime.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------