safe_strcpy etc

Luke Kenneth Casson Leighton lkcl at switchboard.net
Fri Jun 12 12:46:34 GMT 1998


follows is a grep of safe_strcpy *.c.  all occurrences (except those that
i have added in nisppass.c, which are bugs) have "-1" on them, which i
think is silly.

p.s why does the one in trans2.c have "-2"?

client.c:	  case 0x01: safe_strcpy(status,"held or stopped", sizeof(status)-1); break;
client.c:	  case 0x02: safe_strcpy(status,"printing",sizeof(status)-1); break;
client.c:	  case 0x03: safe_strcpy(status,"awaiting print", sizeof(status)-1); break;
client.c:	  case 0x04: safe_strcpy(status,"in intercept",sizeof(status)-1); break;
client.c:	  case 0x05: safe_strcpy(status,"file had error",sizeof(status)-1); break;
client.c:	  case 0x06: safe_strcpy(status,"printer error",sizeof(status)-1); break;
client.c:	  default: safe_strcpy(status,"unknown",sizeof(status)-1); break;
make_smbcodepage.c:    safe_strcpy(newbuf_p, cp, *size - (newbuf_p - newbuf));
mangle.c:      safe_strcpy( extension, "___", 3 );
nisppass.c:	safe_strcpy(nisname, "[user_rid=", sizeof(nisname)-1);
nisppass.c:	safe_strcpy(nisname, "[uid=", sizeof(nisname)-1);
nisppass.c:	safe_strcpy(nisname, "[name=", sizeof(nisname)-1);
nisppass.c:	safe_strcpy(val, len, ENTRY_VAL(new_obj, col));
nisppass.c:	safe_strcpy(acb, pdb_encode_acct_ctrl(newpwd->acct_ctrl), sizeof(acb)); 
passdb.c:			safe_strcpy(p, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX", 33);
passdb.c:			safe_strcpy(p, "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", 33);
password.c:    (void) safe_strcpy(realm, KRB_REALM, sizeof (realm) - 1);
smbpass.c:      safe_strcpy((char *)p, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
smbpass.c:      safe_strcpy((char *)p, "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
smbpass.c:      safe_strcpy((char *)p, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
smbpass.c:      safe_strcpy((char *)p, "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
trans2.c:          safe_strcpy( p+1, expnd, sizeof(mask) - (p - mask) - 2);
util.c:  safe_strcpy(ret,s,len);
util.c:char *safe_strcpy(char *dest, char *src, int maxlength)
util.c:        DEBUG(0,("ERROR: NULL dest in safe_strcpy\n"));
util.c:	    DEBUG(0,("ERROR: string overflow by %d in safe_strcpy [%.50s]\n",



More information about the samba-technical mailing list