netif_stop_queue() not called in xmit()

[David Gibson]

On Sat, Mar 09, 2002 at 04:08:33PM -0800, Steve J wrote:
> Hi,
> I am working with orinoco.c (0.08) provided in
> pcmcia-cs-3.1.31, on 2.4.12 kernel.
> 
> In dldwd_xmit function() when the Packet transmission
> is initiated, the netif_stop_queue(dev) is not
> invoked. 
> THough in orinoco.c (0.08a) it is invoked.
> 
> Kindly tell, why is it not invoked in 0.08 OR how the
> stopping mechanism is built in 0.08.
> 
> Should I add the netif_stop_queue() statement to 0.08
> as in 0.08a.

Interesting.  netif_stop_queue() is called in 0.08 as I distributed
it, but apparently not as it appears in pcmcia-cs-3.1.31.  I assume
David Hinds must have made a mistake when he ported it to pcmcia-cs.

-- 
David Gibson			| For every complex problem there is a
david at gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.  -- H.L. Mencken
http://www.ozlabs.org/people/dgibson