memory leakage in libsmbclient and proposed patch

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerald (Jerry) Carter wrote:
| Jeremy Allison wrote:
| | On Fri, Oct 22, 2004 at 03:13:57AM +0200, Sorin Manolache wrote:
| |
| |>As I previously posted on smb-clients, I suspect libsmbclient leaks
| |>memory if one attempts to connect to a computer that is down or does
| |>not run samba.
| |>
| |>I propose the attached patch. The patch is for samba-3.0.7
| |>(samba-latest.tar.gz, 22 Oct 2004).
| |
| |
| | Applied, thanks !
|
| Gahhh!!!  Test this.  And see my previous mail about why
| the change was pulled out.

ok.  I'll pull the feathers out of my mouth.  This was the change
I was thinking of that broke smbfs.

svn diff -r3:76 $SVNURL/branches/SAMBA_3_0/source/libsmb/clientgen.c

The patch to smbc_server() looks safe.  Sorry for not getting
all my facts straight before.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBfnWYIR7qMdg1EfYRAkRzAJ98ZBWjXUyqXO2/LSiSh/WPbkOeOwCfaqVv
H+dYRFHi9PtBF+ITFz2r/so=
=lLD8
-----END PGP SIGNATURE-----