[Samba] Samba 4.22 breaks Time Machine

[jdistler-samba at golem.ph.utexas.edu]

> On Mar 10, 2025, at 09:06, Ralph Boehme via samba <samba at lists.samba.org> wrote:
> 
> Can you try the attached completely untested patch? It should fix the rename issue and from quickly scanning the code it shouldn't have unwanted side effects, at least not on a Time Machine only share.

I did apply the patch, and it seems to be working OK (so no longer "completely untested", just "mostly untested").

But if fixing this issue is as simple as setting

     fsp->fsp_flags.posix_open = true;

in a Share, why not make that a configuration option?

(I assume that macOS's Time Machine is not the only client that relied on fruit:posix_rename, just the most common one.)