[Samba] missing msdfs referrals from samba directory listing: wrong order in smbd_dirptr_get_entry()?

[Kees van Vloten]

On 07-06-2024 06:59, Michael Tokarev via samba wrote:
> 07.06.2024 07:54, Jeremy Allison wrote:
>>> msdfs is broken in 4.19.  It worked fine in 4.18.
>
> This is not entirely true.
>
>>> Is no one using msdfs?  I wonder why I was the first to discover this?
>>
>> There must not be a test for your specific use-case.
>>
>> MSDFS is tested in the autobuild test suite. Can
>> you articulate the problem well enough we can
>> build a regression test for it, and then we
>> can ensure it never gets broken for this case
>> again.
>
> I hoped this is obvious even from the subject line :)
>
> with 4.19, msdfs reparse points are missing from the directory *listing*
> from samba.  When specifying the msdfs name directly, samba uses it 
> fine -
> and this is covered by the tests.  But there's no test which checks the
> msdfs entry in the file *listing* generated by samba.
>
> With my question above - "is no one using msdfs?" - I'm not sure it is
> worth the effort to actually fix this for 4.19.  Maybe it is if the fix
> would be simple.

I am using msdfs, but I haven't run into issues (or I did not notice 
them yet) with 4.19.

There is a little difference with your config: I am not using symlinks 
in the filesystem but 'msdfs proxy' in smb.conf.  Not sure if that can 
be related to your finding?

- Kees.

>
> Thanks,
>
> /mjt