[Samba] 4.21-rc: ldb_version.h is missing

[Douglas Bagnall]

On 30/07/24 22:20, Michael Tokarev via samba wrote:
> When building libldb as public library, its install target does not
> install ldb_version.h header file, which is included from ldb.h, so
> the resulting header files are unusable.

It may be that 625fb48326ec62a33ce0abdbfb0f6f3d33d7cc64 accidentally reversed the logic:

                             target='include/ldb_version.h',
                             public_headers='include/ldb_version.h',
-                            public_headers_install=not private_library)
+                            public_headers_install=not bld.env.ldb_is_public_library)

     t.env.LDB_VERSION = LDB_VERSION

from "not private" to "not is_public"?

Douglas