[Samba] 4.21-rc: ldb_version.h is missing

[Andrew Bartlett]

On Sat, 2024-08-03 at 21:33 +0300, Michael Tokarev wrote:
> 31.07.2024 08:30, Douglas Bagnall via samba пишет:
> > On 30/07/24 22:20, Michael Tokarev via samba wrote:
> > > When building libldb as public library, its install target does not
> > > install ldb_version.h header file, which is included from ldb.h, so
> > > the resulting header files are unusable.
> > 
> > It may be that 625fb48326ec62a33ce0abdbfb0f6f3d33d7cc64 accidentally reversed the logic:
> > 
> >                               target='include/ldb_version.h',
> >                               public_headers='include/ldb_version.h',
> > -                            public_headers_install=not private_library)
> > +                            public_headers_install=not bld.env.ldb_is_public_library)
> > 
> >       t.env.LDB_VERSION = LDB_VERSION
> > 
> > from "not private" to "not is_public"?
> 
> The logic suggests "public_headers_install=bld.env.ldb_is_public_library"
> (without the "not" part).  Lemme see... yes, the "not" should be removed
> and it works fine.
> 
> Thanks,
> 
> /mjt

Sorry about that, I should go back to boolean logic school ;-)

Andrew Bartlett

-- 
Andrew Bartlett (he/him) https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Developer, Catalyst IT https://catalyst.net.nz/services/samba