[Samba] sysvol-reset deletes delegation ACL

Simon FONTENEAU sfonteneau at tranquil.it
Tue Nov 14 10:02:45 UTC 2023

I understand.
I'm not really good at writing tests. 😕

I also made an improvement to make the sysvol reset faster (Important 
when there are a lot of gpo) :

I've never suggested it since I haven't written a test.
I'm putting this here if it helps you...


Le 13/11/2023 à 18:03, Ralph Boehme via samba a écrit :
> On 11/13/23 17:53, Simon FONTENEAU via samba wrote:
>> Thank you I understand better with the gitlab link.
>> Failing to have this commit accepted, we should perhaps revert this 
>> commit which is a regression :
>> https://gitlab.com/samba-team/samba/-/commit/27dd0afb62d4f7427c966e984c7c8b01bc4d93b5 
> for certain reasons this is not how development works. :) These days 
> we always require tests for all changes. Yes, this sometimes sucks in 
> the short term, but this is that ensures quality in the long run.
> Maybe one of your engineers can contribute and write a test? That 
> would be awesome!
> -slow

More information about the samba mailing list