[Samba] Permissions on rpcd_classic and missing logrotate config

[Michael Tokarev]

23.01.2023 11:27, Matthias Kühne | Ellerhold Aktiengesellschaft via samba wrote:
> Hello fellow samba users,
> 
> we're using Samba 4.16 from corpit.ru/mjt/samba in debian 11 and having
> some problems (I guess?).
> 
> Weve got two problems in that configuration that may be less samba
> related but more packaging related. Nethertheless input is valuable from
> samba itself.
> 
> Our first problem is the permissions for the log.rpcd_class file.
> 
> [2023/01/20 17:30:19.408261,  0] ../../lib/util/debug.c:1224(reopen_one_log)
> Jan 20 17:30:19 fileserver rpcd_classic[497878]:   reopen_one_log:
> Unable to open new log file '/var/log/samba/log.rpcd_classic':
> Permission denied

This one I can not comment for now, looks like it is a samba problem indeed.
I don't even know what this service is for, and how to use it. IIRC, it is
something new in 4.16.

..
> During debug we've discovered a second problem: the logrotate
> configuration is incomplete. The following files are not rotated properly:
> 
>    * /var/log/samba/log.rpcd_*
>    * /var/log/samba/log.samba-*
>    * /var/log/samba/log.wb-*
>    * /var/log/samba/log.winbindd-*

I haven't looked at the logrotate config in the package since I inherited it.
You're right, this list needs to be extended with 4.16+ (and it looks like
it needed to be extended even before 4.16).  I'm tempted to use /var/log/samba/log.*
pattern in there because of the changing nature of these files and because of
the possibility to use log.%m (or log.%I) patterns in there too.

> @Samba: Can you tell us which services needs to be reloaded for which
> files?

This is a good question.  I'm not sure it needs to be reloaded at all though -
I'll take a look.

> @MJT: Can you add this logrotate config to the packages pls?

I don't plan to change 4.16 packages at this time, besides adding upstream
releases as they come. But I sure will include the logrotate changes into
4.17/4.18 packages for debian (and hence ubuntu).

Thank you for noticing this omission!

/mjt