[Samba] Trouble cross compiling samba 4.15.5 with glibc 2.11. Problem with samba-bgqd.c

Berto Furth bertofurth at sent.com
Mon Mar 14 11:03:42 UTC 2022


On Mon, 14 Mar 2022, at 21:41, Rowland Penny via samba wrote:
> On Mon, 2022-03-14 at 12:55 +1300, Andrew Bartlett via samba wrote:
>> On Mon, 2022-03-14 at 10:29 +1100, Berto Furth via samba wrote:
>> > Do you think that if I raised a samba bug that there'd be any hope
>> > of
>> > getting this include statement added to samba-bgqd.c ? Can anyone
>> > suggest something else that might be more elegant to resolve this
>> > issue with compiling samba using glibc 2.11?
>> 
>> As a general rule, we don't include any system headers in our main C
>> files, we have headers in lib/replace that we include, so either
>> include the 'right' header from there or put the extra include,
>> guarded
>> appropriately in a header there.
>> 
>> Then raise a MR I guess: https://wiki.samba.org/index.php/Contribute
>> 
>> Andrew,
>
> Hi Andrew, do we really want to be supporting such an old version of
> glibc in any way ? What is the users 'target platform', could it be it
> is one that depends on SMBv1, the very thing Samba is working to remove
> ?
>
> Rowland

Hi Rowland and Andrew,

As per Andrew's suggestion I was able to add the following "lib/replace" header to samba-bgqd.c to fix the problem

#include "system/wait.h"

The reason I'm compiling version 4.15.5 is so that the platform doesn't have to depend on SMBv1 any more! The original version of samba on the platform was v3.5.16.

See https://github.com/bertofurth/Seagate-Central-Samba for more details.

I've yet to go through the process of submitting the suggested changes. 

Thanks again!

Berto.



More information about the samba mailing list