[Samba] segfault in smbclient 4.13.2?

[Joachim Lindenberg]

Louis just now provided 4.13.4, and the issue is gone.
Thanks a lot!
Joachim

-----Ursprüngliche Nachricht-----
Von: Joachim Lindenberg <samba at lindenberg.one> 
Gesendet: Wednesday, 3 March 2021 18:44
An: 'samba at lists.samba.org' <samba at lists.samba.org>
Betreff: AW: [Samba] segfault in smbclient 4.13.2?

Thanks, then definitely I am looking forward to 4.13.3 or 4.
Best Regards, Joachim

-----Ursprüngliche Nachricht-----
Von: samba <samba-bounces at lists.samba.org> Im Auftrag von Andrew Bartlett via samba
Gesendet: Wednesday, 3 March 2021 18:42
An: Joachim Lindenberg <samba at lindenberg.one>; samba at lists.samba.org
Betreff: Re: [Samba] segfault in smbclient 4.13.2?

Looks like a known issue to me.  Try 4.13.3:
https://www.samba.org/samba/history/samba-4.13.3.html

commit 9f24b5098f796f364a3f403ad4e9ae28b3c0935a
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 28 15:03:41 2020 +0200

    smbclient: Fix recursive mget
    
    Make do_mget rely on do_list() already doing the recursion in a
    breadth-first manner. The previous code called do_list() from within
    its callback. Unfortunately the recent simplifications of do_list()
    broke this, leading to recursive mget to segfault. Instead of figuring
    out how this worked before the simplifications in do_list() (I did
    spend a few hours on this) and fixing it, I chose to restructure
    do_mget() to not recursively call do_list() anymore but instead rely
    on do_list() to do the recursion. Saves quite a few lines of code and
    complexity.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14517
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Sep 30 17:23:45 UTC 2020 on sn-devel-
184



On Wed, 2021-03-03 at 17:57 +0100, Joachim Lindenberg via samba wrote:
> Hello,
> 
>  
> 
> 
> As part of my replication script for sysvol, I am using the following excerpt:
> 
>  
> 
> 
> mkdir /tmp/samba/sysvolcopy
> 
> cd /tmp/samba/sysvolcopy
> 
> peer='cobra.samba.lindenberg.one'
> 
> smbclient \\\\$peer\\sysvol 'password' -UJoachim -e --max-protocol SMB3  -c "prompt; recurse; mget *"
> 
>  
> 
> 
> with 4.13.2-Debian running on Ubuntu 20.04 I get
> 
>  
> 
> 
> getting file
> \samba.lindenberg.one\Policies\{06C651B1-01BC-4B53-8497-40CFD30F94C2}\
> GPT.INI of size 59 as GPT.INI (0.6 KiloBytes/sec) (average 0.6
> KiloBytes/sec)
> 
> getting file
> \samba.lindenberg.one\Policies\{06C651B1-01BC-4B53-8497-40CFD30F94C2}\
> Machine\comment.cmtx of size 1396 as comment.cmtx (13.0 KiloBytes/sec) 
> (average 6.9 KiloBytes/sec)
> 
> getting file
> \samba.lindenberg.one\Policies\{06C651B1-01BC-4B53-8497-40CFD30F94C2}\
> Machine\Registry.pol of size 2294 as Registry.pol (20.7 KiloBytes/sec) 
> (average 11.6 KiloBytes/sec)
> 
> ./bug.sh: line 4:  3620 Segmentation fault      (core dumped) smbclient \\\\$peer\\sysvol 'password' -UJoachim -e --max-protocol SMB3 -c "prompt; recurse; mget *"
> 
>  
> 
> 
> Whereas with 4.12.11 the script runs through all my sysvol successfully.
> 
> Is this a know bug in 4.13? An ACL issue? Anything else to check?
> 
>  
> 
> 
> Thanks, Joachim
> 
>  
> 
> 
>  
> 
> 

-- 
Andrew Bartlett (he/him)        https://samba.org/~abartlet/
Samba Team Member (since 2001)  https://samba.org
Samba Developer, Catalyst IT    https://catalyst.net.nz/services/samba



--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba