[Samba] getting (FreeBSD port) patches upstream first
abartlet at samba.org
Wed Aug 26 01:11:15 UTC 2020
On Tue, 2020-08-25 at 14:12 -0400, Andrew Walker via samba wrote:
> On Tue, Aug 25, 2020 at 1:17 PM James B. Byrne via samba <
> samba at lists.samba.org> wrote:
> > On Mon, August 24, 2020 22:19, Andrew Bartlett wrote:
> > >
> > > A bit of an aside, but it would be incredibly awesome if the
> > > FreeBSD
> > > port could adopt the same policy as, eg, Debian and not ship any
> > > patches that are not upstream.
> > >
> > I believe that Timur has indeed submitted patches of this nature.
> Timur did attempt to upstream the talloc patch here:
I've looked this over, and this is exactly the right example, as it
happens. There was a great discussion about the patch, and ultimately
it was rejected.
This is good feedback, and should not have been ignored in my view.
Note that I said 'are not upstream', not 'have not been submitted
The gap between those two things ends up being the issue here, which is
when patches we (as the Samba Team) don't agree with are still applied
by distributors and porters, all the QA, experience etc applied to
Samba.org releases is just discarded.
It also just makes bug triage much harder, and we have seen here that
triage of FreeBSD issues is hard enough right now.
Now of course there are always matters of degree in this, but is is an
important principle to start with.
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT - Expert Open Source
More information about the samba